linux-kernel - Re: [PATCH -next] acpi: fpdt: drop errant comma in pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jan 2021 15:56:37 -0800
From:   Joe Perches <joe@...ches.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH -next] acpi: fpdt: drop errant comma in pr_info()

On Thu, 2021-01-28 at 15:25 -0800, Randy Dunlap wrote:
> Drop a mistaken comma in the pr_info() args to prevent the
> build warning.
> 
> ../drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
> ../include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
> ../drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro 'pr_info'
>     pr_info(FW_BUG, "Invalid subtable type %d found.\n",
[]
> --- linux-next-20210128.orig/drivers/acpi/acpi_fpdt.c
> +++ linux-next-20210128/drivers/acpi/acpi_fpdt.c
> @@ -252,7 +252,7 @@ void acpi_init_fpdt(void)
>  					      subtable->type);
>  			break;
>  		default:
> -			pr_info(FW_BUG, "Invalid subtable type %d found.\n",
> +			pr_info(FW_BUG "Invalid subtable type %d found.\n",
>  			       subtable->type);

Another question would be why is the pr_info when all the other
FW_BUG uses in this file are pr_err

One would think it's at least a defect of some time.
I would think it should at least be pr_notice or pr_warn

Documentation/admin-guide/kernel-parameters.txt-                        1 (KERN_ALERT)          action must be taken immediately
Documentation/admin-guide/kernel-parameters.txt-                        2 (KERN_CRIT)           critical conditions
Documentation/admin-guide/kernel-parameters.txt-                        3 (KERN_ERR)            error conditions
Documentation/admin-guide/kernel-parameters.txt-                        4 (KERN_WARNING)        warning conditions
Documentation/admin-guide/kernel-parameters.txt-                        5 (KERN_NOTICE)         normal but significant condition
Documentation/admin-guide/kernel-parameters.txt:                        6 (KERN_INFO)           informational
Documentation/admin-guide/kernel-parameters.txt-                        7 (KERN_DEBUG)          debug-level messages