linux-kernel - Re: [PATCH v8] perf stat: Fix wrong skipping for per-die aggregation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58796d6e-fceb-ea1f-3a83-543569d5625c@linux.intel.com>
Date:   Thu, 28 Jan 2021 09:25:57 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com, ying.huang@...el.com
Subject: Re: [PATCH v8] perf stat: Fix wrong skipping for per-die aggregation

Hi Jiri,

On 1/28/2021 6:08 AM, Jiri Olsa wrote:
>> @@ -1385,7 +1386,8 @@ void evsel__exit(struct evsel *evsel)
>>   	zfree(&evsel->group_name);
>>   	zfree(&evsel->name);
>>   	zfree(&evsel->pmu_name);
>> -	zfree(&evsel->per_pkg_mask);
> sorry I did not notice before, but I think we need to call
> zero_per_pkg in here, otherwise we're leaking keys
> 
> jirka
> 

Sorry, I forgot to add the release code here. :(

I will rename zero_per_pkg to evsel__zero_per_pkg and move it to evsel.c and call 
evsel__zero_per_pkg in evsel__exit().

Thanks
Jin Yao