linux-kernel - [PATCH] iwlwifi: mvm: remove redundant initialization of variable phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210128163947.643705-1-colin.king@canonical.com>
Date:   Thu, 28 Jan 2021 16:39:47 +0000
From:   Colin King <colin.king@...onical.com>
To:     Luca Coelho <luciano.coelho@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Johannes Berg <johannes.berg@...el.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] iwlwifi: mvm: remove redundant initialization of variable phy_id

From: Colin Ian King <colin.king@...onical.com>

The variable phy_id is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/quota.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/quota.c b/drivers/net/wireless/intel/iwlwifi/mvm/quota.c
index 3d0166df2002..4a0ba7f44900 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/quota.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/quota.c
@@ -90,7 +90,7 @@ static void iwl_mvm_adjust_quota_for_noa(struct iwl_mvm *mvm,
 {
 #ifdef CONFIG_NL80211_TESTMODE
 	struct iwl_mvm_vif *mvmvif;
-	int i, phy_id = -1, beacon_int = 0;
+	int i, phy_id, beacon_int = 0;
 
 	if (!mvm->noa_duration || !mvm->noa_vif)
 		return;
-- 
2.29.2