linux-kernel - Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hft2jlnt4.wl-tiwai@suse.de>
Date:   Fri, 29 Jan 2021 17:17:59 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Michael Catanzaro <mcatanzaro@...hat.com>
Cc:     "N, Harshapriya" <harshapriya.n@...el.com>,
        alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        kai.vehmanen@...el.com, stable@...r.kernel.org
Subject: Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM"
 broke
 my
 laptop's internal audio

On Fri, 29 Jan 2021 17:12:08 +0100,
Michael Catanzaro wrote:
> 
> On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro
> <mcatanzaro@...hat.com> wrote:
> > OK, I found "ALSA: hda/via: Apply the workaround generically for
> > Clevo machines" which was just merged yesterday. So I will test
> > again to find out.
> 
> Hi Takashi, hi Harsha,
> 
> I can confirm that the problem is fixed by this commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4961167bf7482944ca09a6f71263b9e47f949851

Thanks, good to hear.

Then I think we can drop the entry from power_save_denylist in
hda_intel.c.  Could you try that it still works with the patch below?


thanks,

Takashi

--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = {
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
-	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
-	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */