linux-kernel - Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <GOHPNQ.RTPVHYRR9NQ62@redhat.com>
Date:   Fri, 29 Jan 2021 11:24:16 -0600
From:   Michael Catanzaro <mcatanzaro@...hat.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     "N, Harshapriya" <harshapriya.n@...el.com>,
        alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        kai.vehmanen@...el.com, stable@...r.kernel.org
Subject: Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke
 my
 laptop's internal audio

On Fri, Jan 29, 2021 at 5:17 pm, Takashi Iwai <tiwai@...e.de> wrote:
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk 
> power_save_denylist[] = {
>  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
>  	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
>  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
> -	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
> -	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
>  	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
>  	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
>  	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA 
> dev */

Hi,

This patch works fine on my laptop. I have no clue whether that means 
it's really safe to remove the quirk. I've never noticed any clicking 
noise myself, but I understand it has been a problem for other System76 
laptops.

Michael