linux-kernel - Re: [PATCH 3/3] serial: 8250: remove UART_CAP_TEMT on PORT_16550A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <22d98a58-724c-a563-d55c-7c18b5271ec7@distech-controls.com>
Date:   Fri, 29 Jan 2021 13:04:04 -0500
From:   Eric Tremblay <etremblay@...tech-controls.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     gregkh@...uxfoundation.org, jslaby@...e.com,
        matwey.kornilov@...il.com, giulio.benetti@...ronovasrl.com,
        lukas@...ner.de, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        christoph.muellner@...obroma-systems.com, heiko@...ech.de,
        heiko.stuebner@...obroma-systems.com
Subject: Re: [PATCH 3/3] serial: 8250: remove UART_CAP_TEMT on
 PORT_16550A_FSL64

On 2021-01-29 6:25 a.m., Andy Shevchenko wrote:
> On Thu, Jan 28, 2021 at 06:36:29PM -0500, Eric Tremblay wrote:
>> That port does not have an interrupt on TEMT when using
>> the FIFO mode.
> This is wrong.
> 1. You have to guarantee that TEMT is set for all UARTs before this patch
> 2. World is not staying on OF only platforms
>
> NAK

Considering the use of the reversed capability UART_CAP_NOTEMT should I set
the flag directly in uart_config like:

[PORT_16550A_FSL64] = {
		.name		= "16550A_FSL64",
		.fifo_size	= 64,
		.tx_loadsz	= 63,
		.fcr		= UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10 |
				  UART_FCR7_64BYTE,
		.flags		= UART_CAP_FIFO | UART_CAP_NOTEMT,
	},

>