linux-kernel - Re: [PATCH 3/3] serial: 8250: remove UART_CAP_TEMT on PORT_16550A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 Jan 2021 20:42:51 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Eric Tremblay <etremblay@...tech-controls.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        "Matwey V. Kornilov" <matwey.kornilov@...il.com>,
        Giulio Benetti <giulio.benetti@...ronovasrl.com>,
        Lukas Wunner <lukas@...ner.de>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        christoph.muellner@...obroma-systems.com,
        Heiko Stübner <heiko@...ech.de>,
        Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
Subject: Re: [PATCH 3/3] serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64

On Fri, Jan 29, 2021 at 8:07 PM Eric Tremblay
<etremblay@...tech-controls.com> wrote:
> On 2021-01-29 6:25 a.m., Andy Shevchenko wrote:

...

> Considering the use of the reversed capability UART_CAP_NOTEMT should I set
> the flag directly in uart_config like:
>
> [PORT_16550A_FSL64] = {
>                 .name           = "16550A_FSL64",
>                 .fifo_size      = 64,
>                 .tx_loadsz      = 63,
>                 .fcr            = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10 |
>                                   UART_FCR7_64BYTE,
>                 .flags          = UART_CAP_FIFO | UART_CAP_NOTEMT,
>         },

This looks much better!

-- 
With Best Regards,
Andy Shevchenko