linux-kernel - Re: [PATCH 0/6] lib/find_bit: fast path for small bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Jan 2021 23:12:06 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Yury Norov <yury.norov@...il.com>
Cc:     linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-SH <linux-sh@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, Arnd Bergmann <arnd@...db.de>,
        Dennis Zhou <dennis@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        David Sterba <dsterba@...e.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Stefano Brivio <sbrivio@...hat.com>,
        "Ma, Jianpeng" <jianpeng.ma@...el.com>,
        Wei Yang <richard.weiyang@...ux.alibaba.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Subject: Re: [PATCH 0/6] lib/find_bit: fast path for small bitmaps

On Fri, Jan 29, 2021 at 10:54 PM Yury Norov <yury.norov@...il.com> wrote:
> On Fri, Jan 29, 2021 at 12:45 PM Yury Norov <yury.norov@...il.com> wrote:
> >
> > Bitmap operations are much simpler and faster in case of small bitmaps, whicn
> > fit into a single word. In linux/bitmap.h we have a machinery that allows
> > compiler to replace actual function call with a few instructions if bitmaps
> > passed into the function is small and its size is known at compile time.
> >
> > find_*_bit() API lacks this functionality; despite users will benefit from it
> > a lot. One important example is cpumask subsystem, when NR_CPUS <= BITS_PER_LONG.
> > In the very best case, the compiler may replace a find_*_bit() call for such a
> > bitmap with a single ffs or ffz instruction.
> >
> > Tools is synchronized with new implementation where needed.
>
> Sorry for the broken enumeration . If it's too confusing, please let me know
> and I'll resend.

Yeah, please resend with a bumped version and respective changelog.

-- 
With Best Regards,
Andy Shevchenko