linux-kernel - Re: [PATCH] eCryptfs: add a semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210130175711.GB58096@elm>
Date:   Sat, 30 Jan 2021 11:57:11 -0600
From:   Tyler Hicks <code@...icks.com>
To:     Joe Perches <joe@...ches.com>
Cc:     trix@...hat.com, hannes@...xchg.org, mhocko@...e.com,
        longman@...hat.com, herbert@...dor.apana.org.au,
        ebiggers@...gle.com, ecryptfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eCryptfs: add a semicolon

On 2020-11-27 10:11:23, Joe Perches wrote:
> On Fri, 2020-11-27 at 08:05 -0800, trix@...hat.com wrote:
> > Function like macros should have a semicolon.
> []
> > diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
> []
> > @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
> >  	rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
> >  	if (rc) {
> >  		ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
> > -				cipher_code)
> > +				cipher_code);
> 
> As this is the only use that does not have a semicolon,
> it'd be good to add the removal of the semicolon from
> the #define at the same time.

I double checked that this is the only ecryptfs_printk() usage missing
the trailing semicolon and then made Joe's suggested change before
pushing the patch to the eCryptfs next branch:

 https://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs.git/log/?h=next

Thanks for the cleanup!

Tyler