linux-kernel - 答复: [PATCH -next] ACPI: tables: Mark acpi_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 30 Jan 2021 02:23:31 +0000
From:   "Zouwei (Samuel)" <zou_wei@...wei.com>
To:     Zhang Rui <rui.zhang@...el.com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "lenb@...nel.org" <lenb@...nel.org>
CC:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH -next] ACPI: tables: Mark acpi_init_fpdt with static keyword

Hi Rui, 

You can fix it in your patch together.

-----邮件原件-----
发件人: Zhang Rui [mailto:rui.zhang@...el.com] 
发送时间: 2021年1月29日 14:25
收件人: Zouwei (Samuel) <zou_wei@...wei.com>; rjw@...ysocki.net; lenb@...nel.org
抄送: linux-acpi@...r.kernel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH -next] ACPI: tables: Mark acpi_init_fpdt with static keyword

Hi, Wei,

Thanks for the patch.

Given that there are a couple of things need to be fixed in the orignal patch, I'd prefer to refresh the patch with all the fixes included

https://patchwork.kernel.org/project/linux-acpi/patch/20210129061548.13448-1-rui.zhang@intel.com/

what do you think?

thanks,
rui

On Thu, 2021-01-28 at 19:31 +0800, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/acpi/acpi_fpdt.c:230:6: warning: symbol 'acpi_init_fpdt' was 
> not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/acpi/acpi_fpdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c index 
> b810811..968f9cc 100644
> --- a/drivers/acpi/acpi_fpdt.c
> +++ b/drivers/acpi/acpi_fpdt.c
> @@ -227,7 +227,7 @@ static int fpdt_process_subtable(u64 address, u32
> subtable_type)
>  	return 0;
>  }
>  
> -void acpi_init_fpdt(void)
> +static void acpi_init_fpdt(void)
>  {
>  	acpi_status status;
>  	struct acpi_table_header *header;