linux-kernel - Re: [PATCH 2/3] usb: xhci-mtk: fix UAS issue by XHCI_BROKEN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 31 Jan 2021 15:13:23 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Rosen Penev <rosenp@...il.com>
Cc:     Nicolas Boichat <drinkcat@...omium.org>,
        Devicetree List <devicetree@...r.kernel.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Ikjoon Jang <ikjn@...omium.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/3] usb: xhci-mtk: fix UAS issue by XHCI_BROKEN_STREAMS
 quirk



On 24/12/2020 08:18, Chunfeng Yun wrote:
> On Wed, 2020-12-16 at 19:43 -0800, Rosen Penev wrote:
>> On Wed, Dec 16, 2020 at 6:29 PM Chunfeng Yun <chunfeng.yun@...iatek.com> wrote:
>>>
>>> On Wed, 2020-12-16 at 20:28 +0800, Nicolas Boichat wrote:
>>>> On Wed, Dec 16, 2020 at 7:53 PM Chunfeng Yun <chunfeng.yun@...iatek.com> wrote:
[...]
>>>>>         mtk->lpm_support = of_property_read_bool(node, "usb3-lpm-capable");
>>>>> +       mtk->broken_streams =
>>>>> +               of_property_read_bool(node, "mediatek,broken_streams_quirk");
>>>>
>>>> Would it be better to add a data field to struct of_device_id
>>>> mtk_xhci_of_match, and enable this quirk on mediatek,mt8173-xhci only?
>>> This is the common issue for all SoCs (before 2016.06) with 0.96 xHCI
>>> when the controller don't support bulk stream. If enable this quirk only
>>> for mt8173, then for other SoCs, the compatible need include
>>> "mediatek,mt8173-xhci" in dts, this may be not flexible for some cases,
>>> e.g. a new SoC has the broken stream as mt8173, but also has another
>>> different quirk, the way you suggested will not handle it.
>>> And I plan to remove "mediatek,mt8173-xhci" in mtk_xhci_of_match after
>>> converting the binding to YMAL.
>> I'm guessing this also applies to mt7621?
> Yes, mt7621 doesn't support bulk stream
> 

Then please provide patches to the DTSI for all SoCs that have this problem.
Either as a follow-up or as part of this series, if you need to resubmit.

Regards,
Matthias