linux-kernel - Re: [PATCH v2 1/5] misc: qca639x: add support for QCA639x powerup sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875z3dmbpz.fsf@tynnyri.adurom.net>
Date:   Sun, 31 Jan 2021 16:18:16 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stanimir Varbanov <svarbanov@...sol.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-arm-msm@...r.kernel.org,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH v2 1/5] misc: qca639x: add support for QCA639x powerup sequence

Dmitry Baryshkov <dmitry.baryshkov@...aro.org> writes:

> Qualcomm QCA639x is a family of WiFi + Bluetooth SoCs, with BT part
> being controlled through the UART and WiFi being present on PCIe
> bus. Both blocks share common power sources. Add device driver handling
> power sequencing of QCA6390/1.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
>  drivers/misc/Kconfig        |  12 +++
>  drivers/misc/Makefile       |   1 +
>  drivers/misc/qcom-qca639x.c | 164 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 177 insertions(+)
>  create mode 100644 drivers/misc/qcom-qca639x.c
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index e90c2524e46c..a14f67ab476c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -255,6 +255,18 @@ config QCOM_FASTRPC
>  	  applications DSP processor. Say M if you want to enable this
>  	  module.
>  
> +config QCOM_QCA639X
> +	tristate "Qualcomm QCA639x WiFi/Bluetooth module support"
> +	depends on REGULATOR && PM_GENERIC_DOMAINS
> +	help
> +	  If you say yes to this option, support will be included for Qualcomm
> +	  QCA639x family of WiFi and Bluetooth SoCs. Note, this driver supports
> +	  only power control for this SoC, you still have to enable individual
> +	  Bluetooth and WiFi drivers.
> +
> +	  Say M here if you want to include support for QCA639x chips as a
> +	  module. This will build a module called "qcom-qca639x".

Is this is something you need on ARM platforms? As on x86 this is
definitely not needed, for example it's enough to load ath11k_pci to get
QCA6390 Wi-Fi working. I think the documentation should be clarified
where this QCOM_QCA639X is needed (and it's not needed on normal PCI
devices).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches