linux-kernel - Re: [PATCH] misc: bcm-vk: unlock on error in bcm_to_h_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEuuh2-uNkbK6wsJVBUEXMv2TQdhQaRCqtM0GdULWgVHU+JDnQ@mail.gmail.com>
Date:   Mon, 1 Feb 2021 10:31:49 -0800
From:   Desmond Yan <desmond.yan@...adcom.com>
To:     Scott Branden <scott.branden@...adcom.com>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Olof Johansson <olof@...om.net>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] misc: bcm-vk: unlock on error in bcm_to_h_msg_dequeue()

Yes, in this situation, it is fatal and we would turn off processing
anyway.  But, Dan's change seems more appropriate and proper practice
(thxs for the patch).

Des

On Mon, Feb 1, 2021 at 9:31 AM Scott Branden <scott.branden@...adcom.com> wrote:
>
>
>
> On 2021-02-01 4:22 a.m., Dan Carpenter wrote:
> > Unlock before returning on this error path.
> >
> > Fixes: 111d746bb476 ("misc: bcm-vk: add VK messaging support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> >  drivers/misc/bcm-vk/bcm_vk_msg.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/bcm-vk/bcm_vk_msg.c b/drivers/misc/bcm-vk/bcm_vk_msg.c
> > index eec90494777d..fc972e43258a 100644
> > --- a/drivers/misc/bcm-vk/bcm_vk_msg.c
> > +++ b/drivers/misc/bcm-vk/bcm_vk_msg.c
> > @@ -849,7 +849,8 @@ s32 bcm_to_h_msg_dequeue(struct bcm_vk *vk)
> >                                * that is fatal.
> >                                */
> >                               dev_crit(dev, "Kernel mem allocation failure.\n");
> > -                             return -ENOMEM;
> > +                             total = -ENOMEM;
> > +                             goto idx_err;
> >                       }
> >
> This is a pretty fatal case if we fail to allocate memory here.
> Will let Desmond respond if we wanted to keep the mutex locked forever in this
> case or if we do want to return and keep mutex locked if it is fatal and there is
> no real recovery path.
> >                       /* flush rd pointer after a message is dequeued */
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4163 bytes)