linux-kernel - Re: [PATCH RESEND] random: initialize ChaCha20 constants with correct endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YBiEHO4hKFn9JcdY@sol.localdomain>
Date:   Mon, 1 Feb 2021 14:43:40 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>,
        Jann Horn <jannh@...gle.com>, Theodore Ts'o <tytso@....edu>,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH RESEND] random: initialize ChaCha20 constants with
 correct endianness

On Tue, Jan 12, 2021 at 11:29:27AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> On big endian CPUs, the ChaCha20-based CRNG is using the wrong
> endianness for the ChaCha20 constants.
> 
> This doesn't matter cryptographically, but technically it means it's not
> ChaCha20 anymore.  Fix it to always use the standard constants.
> 
> Cc: linux-crypto@...r.kernel.org
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Jann Horn <jannh@...gle.com>
> Cc: Theodore Ts'o <tytso@....edu>
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
> 
> Andrew, please consider taking this patch since the maintainer has been
> ignoring it for 4 months
> (https://lkml.kernel.org/lkml/20200916045013.142179-1-ebiggers@kernel.org/T/#u).

Ping.