linux-kernel - Re: [PATCH] mm/mempolicy: use helper range_in_vma() in queue_pages_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33c3c6cb-c13d-0bb3-1c65-c16d6ffe0cac@redhat.com>
Date:   Mon, 1 Feb 2021 12:09:41 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Miaohe Lin <linmiaohe@...wei.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/mempolicy: use helper range_in_vma() in
 queue_pages_test_walk()

On 30.01.21 10:13, Miaohe Lin wrote:
> The helper range_in_vma() is introduced via commit 017b1660df89 ("mm:
> migration: fix migration of huge PMD shared pages"). But we forgot to
> use it in queue_pages_test_walk().
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>   mm/mempolicy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 6961238c7ef5..ab51132547b8 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -677,7 +677,7 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
>   	unsigned long flags = qp->flags;
>   
>   	/* range check first */
> -	VM_BUG_ON_VMA((vma->vm_start > start) || (vma->vm_end < end), vma);
> +	VM_BUG_ON_VMA(!range_in_vma(vma, start, end), vma);
>   
>   	if (!qp->first) {
>   		qp->first = vma;
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb