linux-kernel - RE: [PATCH] checkpatch: add warning for line space after "Fixes:" tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <19f201d6f88c$cba69450$62f3bcf0$@samsung.com>
Date:   Mon, 1 Feb 2021 16:54:14 +0530
From:   "Shradha Todi" <shradha.t@...sung.com>
To:     "'Joe Perches'" <joe@...ches.com>, <linux-kernel@...r.kernel.org>
Cc:     <apw@...onical.com>, <pankaj.dubey@...sung.com>,
        "'Lakshay Mehra'" <l.mehra@...sung.com>
Subject: RE: [PATCH] checkpatch: add warning for line space after "Fixes:"
 tag

> -----Original Message-----
> From: Joe Perches <joe@...ches.com>
> Subject: Re: [PATCH] checkpatch: add warning for line space after
"Fixes:" tag
> 
> On Thu, 2021-01-28 at 20:56 +0530, Shradha Todi wrote:
> > Add a check to give warning for line break between Fixes tag
> > and signature tags as that is the commonly followed style.
> >
> > Also add a --fix option to delete space lines after "Fixes:" tag.
> >
> > Signed-off-by: Lakshay Mehra <l.mehra@...sung.com>
> > Signed-off-by: Shradha Todi <shradha.t@...sung.com>
> > ---
> >  scripts/checkpatch.pl | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 92e888e..6c144c5 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -3027,6 +3027,15 @@ sub process {
> >  			$commit_log_long_line = 1;
> >  		}
> >
> >
> > +# Check for no line break after Fixes
> > +		if ($line =~ /^\s*Fixes:/i && $rawlines[$linenr] =~
/^\s*$/) {
> > +			if (WARN("UNNECESSARY_NEWLINE",
> > +				 "Newline is not required after Fixes:\n" .
> $herecurr) &&
> > +			    $fix) {
> > +				fix_delete_line($fixlinenr+1, $rawline);
> > +			}
> > +		}
> 
> I think this isn't necessary and $rawlines[$linenr] may be not exist.
> 

I recently submitted a patch with the fixes tag followed by a line break
and then SOB.
I received a comment saying "no line space between Fixes and SOB" [1].
So my intention of adding this was to save the maintainers time from these
silly mistakes.
Any suggestions for improving this patch? Thanks a ton for the prompt
review.
[1]: https://lkml.org/lkml/2021/1/6/291