linux-kernel - Re: [PATCH v3 0/2] Let illegal access to user-space memory die

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee1f254d-a06e-9725-57d1-ce0210751c05@codethink.co.uk>
Date:   Mon, 1 Feb 2021 13:18:36 +0000
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     Palmer Dabbelt <palmer@...belt.com>, tesheng@...estech.com
Cc:     aou@...s.berkeley.edu, linux-kernel@...r.kernel.org,
        peterx@...hat.com, penberg@...nel.org,
        Paul Walmsley <paul.walmsley@...ive.com>,
        akpm@...ux-foundation.org, walken@...gle.com,
        linux-riscv@...ts.infradead.org, vbabka@...e.cz
Subject: Re: [PATCH v3 0/2] Let illegal access to user-space memory die

On 22/12/2020 02:35, Palmer Dabbelt wrote:
> On Thu, 03 Dec 2020 21:42:57 PST (-0800), tesheng@...estech.com wrote:
>> Accesses to user-space memory without calling uaccess routine
>> leads to hanging in page fault handler. Like arm64, we let it
>> die earlier in page fault handler.
>>
>> Changes in v3:
>>     -Let no_context() use die_kernel_fault() helper
>>
>> Changes in v2:
>>     -Add a die_kernel_fault() helper
>>     -Split one long line code into two
>>
>> Eric Lin (2):
>>   riscv/mm: Introduce a die_kernel_fault() helper function
>>   riscv/mm: Prevent kernel module to access user memory without uaccess
>>     routines
>>
>>  arch/riscv/mm/fault.c | 28 ++++++++++++++++++++++------
>>  1 file changed, 22 insertions(+), 6 deletions(-)
> 
> Thanks, these will be on for-next when the merge window ends.

Just tested this and it seems to be working.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html