linux-kernel - Re: [PATCH v5 4/4] ima: Support EC keys for signature verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4162571.1612185598@warthog.procyon.org.uk>
Date:   Mon, 01 Feb 2021 13:19:58 +0000
From:   David Howells <dhowells@...hat.com>
To:     Vitaly Chikunov <vt@...linux.org>
Cc:     dhowells@...hat.com, Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, patrick@...terwijk.org,
        linux-integrity@...r.kernel.org,
        Stefan Berger <stefanb@...ux.ibm.com>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
Subject: Re: [PATCH v5 4/4] ima: Support EC keys for signature verification

Vitaly Chikunov <vt@...linux.org> wrote:

> > +static inline
> > +const struct public_key *asymmetric_key_public_key(const struct key *key)
> > +{
> > +	return key->payload.data[asym_crypto];
> > +}
> 
> I wonder why use this accessor which does nothing else, because in all
> other places payload.data[asym_crypto] accessed directly.

We should probably move to using wrappers rather than accessing directly for
type safety.

David