linux-kernel - Re: [PATCH 1/2] Clear sensor data after chip write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210202002456.GA117432@roeck-us.net>
Date:   Mon, 1 Feb 2021 16:24:56 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Erik Rosen <erik.rosen@...ormote.com>
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH 1/2] Clear sensor data after chip write

On Mon, Feb 01, 2021 at 08:59:28PM +0100, Erik Rosen wrote:
> Set the sensor->data field to -ENODATA to force a chip access next time
> the sensor value is read.
> 
> Signed-off-by: Erik Rosen <erik.rosen@...ormote.com>

Applied. Please remember to add subsystem and driver to future patches.
In this case, I added:

hwmon: (pmbus) ...

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/pmbus_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index 192442b3b7a2..e27f23eee1e3 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -974,7 +974,7 @@ static ssize_t pmbus_set_sensor(struct device *dev,
>  	if (ret < 0)
>  		rv = ret;
>  	else
> -		sensor->data = regval;
> +		sensor->data = -ENODATA;
>  	mutex_unlock(&data->update_lock);
>  	return rv;
>  }