linux-kernel - Re: [PATCH 2/2] Remove unnecessary pmbus_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210202002641.GA117591@roeck-us.net>
Date:   Mon, 1 Feb 2021 16:26:41 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Erik Rosen <erik.rosen@...ormote.com>
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH 2/2] Remove unnecessary pmbus_clear_cache function call

On Mon, Feb 01, 2021 at 08:59:29PM +0100, Erik Rosen wrote:
> It is no longer necessary to clear the cache to update the sensor value
> from the chip.
> 
> Signed-off-by: Erik Rosen <erik.rosen@...ormote.com>

Applied, after prepending subject with "hwmon: (pmbus/lm25066)".

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/lm25066.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/hwmon/pmbus/lm25066.c b/drivers/hwmon/pmbus/lm25066.c
> index c75a6bf39641..e9a66fd9e144 100644
> --- a/drivers/hwmon/pmbus/lm25066.c
> +++ b/drivers/hwmon/pmbus/lm25066.c
> @@ -371,21 +371,18 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg,
>  	case PMBUS_VIN_OV_WARN_LIMIT:
>  		word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
>  		ret = pmbus_write_word_data(client, 0, reg, word);
> -		pmbus_clear_cache(client);
>  		break;
>  	case PMBUS_IIN_OC_WARN_LIMIT:
>  		word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
>  		ret = pmbus_write_word_data(client, 0,
>  					    LM25066_MFR_IIN_OC_WARN_LIMIT,
>  					    word);
> -		pmbus_clear_cache(client);
>  		break;
>  	case PMBUS_PIN_OP_WARN_LIMIT:
>  		word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
>  		ret = pmbus_write_word_data(client, 0,
>  					    LM25066_MFR_PIN_OP_WARN_LIMIT,
>  					    word);
> -		pmbus_clear_cache(client);
>  		break;
>  	case PMBUS_VIRT_VMON_UV_WARN_LIMIT:
>  		/* Adjust from VIN coefficients (for LM25056) */
> @@ -393,7 +390,6 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg,
>  		word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
>  		ret = pmbus_write_word_data(client, 0,
>  					    LM25056_VAUX_UV_WARN_LIMIT, word);
> -		pmbus_clear_cache(client);
>  		break;
>  	case PMBUS_VIRT_VMON_OV_WARN_LIMIT:
>  		/* Adjust from VIN coefficients (for LM25056) */
> @@ -401,7 +397,6 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg,
>  		word = ((s16)word < 0) ? 0 : clamp_val(word, 0, data->rlimit);
>  		ret = pmbus_write_word_data(client, 0,
>  					    LM25056_VAUX_OV_WARN_LIMIT, word);
> -		pmbus_clear_cache(client);
>  		break;
>  	case PMBUS_VIRT_RESET_PIN_HISTORY:
>  		ret = pmbus_write_byte(client, 0, LM25066_CLEAR_PIN_PEAK);