[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 2 Feb 2021 08:48:50 +0000
From: "C, Udhayakumar" <udhayakumar.c@...el.com>
To: Rob Herring <robh@...nel.org>,
"mgross@...ux.intel.com" <mgross@...ux.intel.com>
CC: "palmerdabbelt@...gle.com" <palmerdabbelt@...gle.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"dragan.cvetic@...inx.com" <dragan.cvetic@...inx.com>,
"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
"jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
"arnd@...db.de" <arnd@...db.de>, "bp@...e.de" <bp@...e.de>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"markgross@...nel.org" <markgross@...nel.org>,
"shawnguo@...nel.org" <shawnguo@...nel.org>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"damien.lemoal@....com" <damien.lemoal@....com>,
"corbet@....net" <corbet@....net>,
"peng.fan@....com" <peng.fan@....com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v4 32/34] dt-bindings: misc: hddl_dev: Add hddl device
management documentation
> On Fri, 29 Jan 2021 18:21:22 -0800, mgross@...ux.intel.com wrote:
> > From: "C, Udhayakumar" <udhayakumar.c@...el.com>
> >
> > Add hddl device management documentation
> >
> > The HDDL client driver acts as an software RTC to sync with network time.
> > It abstracts xlink protocol to communicate with remote IA host.
> > This driver exports the details about sensors available in the
> > platform to remote IA host as xlink packets.
> > This driver also handles device connect/disconnect events and
> > identifies board id and soc id using gpio's based on platform configuration.
> >
> > Cc: Rob Herring <robh+dt@...nel.org>
> > Cc: devicetree@...r.kernel.org
> > Signed-off-by: C Udhayakumar <udhayakumar.c@...el.com>
> > Signed-off-by: Mark Gross <mgross@...ux.intel.com>
> > ---
> > .../bindings/misc/intel,hddl-client.yaml | 114 ++++++++++++++++++
> > 1 file changed, 114 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/misc/intel,hddl-client.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/misc/intel,hddl-
> client.example.dt.yaml: example-0: hddl@...20000:reg:0: [0, 540147712, 0,
> 2048] is too long
> From schema: /usr/local/lib/python3.8/dist-
> packages/dtschema/schemas/reg.yaml
>
> See https://patchwork.ozlabs.org/patch/1433603
>
This lint warning is due to missing address-cells and size-cells fields.
make dt_binding_check dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/misc/intel,hddl-client.yaml
SCHEMA Documentation/devicetree/bindings/processed-schema.yaml
CHKDT Documentation/devicetree/bindings/misc/intel,hddl-client.yaml
DTC Documentation/devicetree/bindings/misc/intel,hddl-client.example.dt.yaml
CHECK Documentation/devicetree/bindings/misc/intel,hddl-client.example.dt.yaml
Will update the fix in next patch version.
---
Thanks,
Udhay
> This check can fail if there are any dependencies. The base for a patch series
> is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
Powered by blists - more mailing lists