linux-kernel - Re: [PATCH] misc: rtsx: modify rts522a init flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 06:27:38 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     ricky_wu@...ltek.com
Cc:     arnd@...db.de, gregkh@...uxfoundation.org, yuehaibing@...wei.com,
        ulf.hansson@...aro.org, bhelgaas@...gle.com,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] misc: rtsx: modify rts522a init flow

The subject line could be more descriptive.  All patches modify
something, so the only real information it contains is "rts522a" and
"init".  Maybe it could say something about powering off OCP (whatever
that is) when no memory card is present.

On Tue, Feb 02, 2021 at 06:56:41PM +0800, ricky_wu@...ltek.com wrote:
> From: Ricky Wu <ricky_wu@...ltek.com>
> 
> Power down OCP for power consumption
> when card is not exist at init_hw()

I assume "card is not exist" means "no SD/MMC card is present".

Why do you only do this for 5227?  "card_exist" seems to be a generic
concept (it's in struct rtsx_pcr and set by the generic
rtsx_pci_init_hw()).  Could/should this be done for other card readers
as well?

> Cc: stable@...r.kernel.org

Per https://www.kernel.org/doc/html/v5.10/process/stable-kernel-rules.html
(option 1) this is sufficient.  You should not include
stable@...nel.org in the cc: list above.

> Signed-off-by: Ricky Wu <ricky_wu@...ltek.com>
> ---
>  drivers/misc/cardreader/rts5227.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/misc/cardreader/rts5227.c b/drivers/misc/cardreader/rts5227.c
> index 8859011672cb..8200af22b529 100644
> --- a/drivers/misc/cardreader/rts5227.c
> +++ b/drivers/misc/cardreader/rts5227.c
> @@ -398,6 +398,11 @@ static int rts522a_extra_init_hw(struct rtsx_pcr *pcr)
>  {
>  	rts5227_extra_init_hw(pcr);
>  
> +	/* Power down OCP for power consumption */
> +	if (!pcr->card_exist)
> +		rtsx_pci_write_register(pcr, FPDCTL, OC_POWER_DOWN,
> +				OC_POWER_DOWN);
> +
>  	rtsx_pci_write_register(pcr, FUNC_FORCE_CTL, FUNC_FORCE_UPME_XMT_DBG,
>  		FUNC_FORCE_UPME_XMT_DBG);
>  	rtsx_pci_write_register(pcr, PCLK_CTL, 0x04, 0x04);
> -- 
> 2.17.1
>