linux-kernel - RE: [PATCH] misc: rtsx: modify rts522a init flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c836b619b5da47c69165a738d7200014@realtek.com>
Date:   Wed, 3 Feb 2021 03:13:58 +0000
From:   吳昊澄 Ricky <ricky_wu@...ltek.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH] misc: rtsx: modify rts522a init flow



> -----Original Message-----
> From: Bjorn Helgaas <helgaas@...nel.org>
> Sent: Tuesday, February 2, 2021 8:28 PM
> To: 吳昊澄 Ricky <ricky_wu@...ltek.com>
> Cc: arnd@...db.de; gregkh@...uxfoundation.org; yuehaibing@...wei.com;
> ulf.hansson@...aro.org; bhelgaas@...gle.com; linux-kernel@...r.kernel.org;
> stable@...r.kernel.org
> Subject: Re: [PATCH] misc: rtsx: modify rts522a init flow
> 
> The subject line could be more descriptive.  All patches modify something, so
> the only real information it contains is "rts522a" and "init".  Maybe it could
> say something about powering off OCP (whatever that is) when no memory
> card is present.
> 

Ok, I will update the subject line at V2 
"misc: rtsx: init of rts522a add power off OCP when no card is present"

> On Tue, Feb 02, 2021 at 06:56:41PM +0800, ricky_wu@...ltek.com wrote:
> > From: Ricky Wu <ricky_wu@...ltek.com>
> >
> > Power down OCP for power consumption
> > when card is not exist at init_hw()
> 
> I assume "card is not exist" means "no SD/MMC card is present".
> 

Right, it's that means, I will modify this description at V2

> Why do you only do this for 5227?  "card_exist" seems to be a generic
> concept (it's in struct rtsx_pcr and set by the generic rtsx_pci_init_hw()).
> Could/should this be done for other card readers as well?
> 

Only rts522a need to do this, other card readers can do HW auto power down

> > Cc: stable@...r.kernel.org
> 
> Per https://www.kernel.org/doc/html/v5.10/process/stable-kernel-rules.html
> (option 1) this is sufficient.  You should not include stable@...nel.org in the
> cc: list above.
> 

I am not very clear, I want this patch to Stable tree, so I added this Tag(Cc: stable@...r.kernel.org)
If I remove this Tag, it means this patch not go to Stable Tree?

Ricky

> > Signed-off-by: Ricky Wu <ricky_wu@...ltek.com>
> > ---
> >  drivers/misc/cardreader/rts5227.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/misc/cardreader/rts5227.c
> > b/drivers/misc/cardreader/rts5227.c
> > index 8859011672cb..8200af22b529 100644
> > --- a/drivers/misc/cardreader/rts5227.c
> > +++ b/drivers/misc/cardreader/rts5227.c
> > @@ -398,6 +398,11 @@ static int rts522a_extra_init_hw(struct rtsx_pcr
> > *pcr)  {
> >  	rts5227_extra_init_hw(pcr);
> >
> > +	/* Power down OCP for power consumption */
> > +	if (!pcr->card_exist)
> > +		rtsx_pci_write_register(pcr, FPDCTL, OC_POWER_DOWN,
> > +				OC_POWER_DOWN);
> > +
> >  	rtsx_pci_write_register(pcr, FUNC_FORCE_CTL,
> FUNC_FORCE_UPME_XMT_DBG,
> >  		FUNC_FORCE_UPME_XMT_DBG);
> >  	rtsx_pci_write_register(pcr, PCLK_CTL, 0x04, 0x04);
> > --
> > 2.17.1
> >
> 
> ------Please consider the environment before printing this e-mail.