linux-kernel - Re: [PATCH 1/2] dm crypt: replaced #if defined with IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Feb 2021 03:33:14 +0300
From:   Dmitry Baryshkov <dbaryshkov@...il.com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     Alasdair Kergon <agk@...hat.com>,
        Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com,
        kernel@...gutronix.de, Arnd Bergmann <arnd@...db.de>,
        kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dm crypt: replaced #if defined with IS_ENABLED

пт, 22 янв. 2021 г. в 11:43, Ahmad Fatoum <a.fatoum@...gutronix.de>:
>
> IS_ENABLED(CONFIG_ENCRYPTED_KEYS) is true whether the option is built-in
> or a module, so use it instead of #if defined checking for each
> separately.
>
> The other #if was to avoid a static function defined, but unused
> warning. As we now always build the callsite when the function
> is defined, we can remove that first #if guard.
>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

Acked-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>


-- 
With best wishes
Dmitry