linux-kernel - Re: [PATCH 1/2] misc/pvpanic: split-up generic and platform dependent code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9080b512-33a8-e9f9-7c4c-bc2572ab7e5c@infradead.org>
Date:   Wed, 3 Feb 2021 09:13:39 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mihai Carabas <mihai.carabas@...cle.com>,
        linux-kernel@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, arnd@...db.de,
        andriy.shevchenko@...ux.intel.com, bobo.shaobowang@...wei.com
Subject: Re: [PATCH 1/2] misc/pvpanic: split-up generic and platform dependent
 code

On 2/3/21 6:43 AM, Mihai Carabas wrote:
> diff --git a/drivers/misc/pvpanic/Kconfig b/drivers/misc/pvpanic/Kconfig
> new file mode 100644
> index 00000000..12bb017
> --- /dev/null
> +++ b/drivers/misc/pvpanic/Kconfig
> @@ -0,0 +1,14 @@
> +config PVPANIC
> +	bool "pvpanic device support"
> +	depends on PVPANIC_MMIO
> +	help
> +	  This option enable generic code for pvpanic device driver logic.
> +
> +config PVPANIC_MMIO
> +	tristate "pvpanic mmio device support"

	                  MMIO


Also capitalize PCI in the other patch in the similar location.

> +	depends on HAS_IOMEM && (ACPI || OF)
> +	select PVPANIC
> +	help
> +	  This driver provides support for the pvpanic device.  pvpanic is
> +	  a paravirtualized device provided by QEMU; it lets a virtual machine
> +	  (guest) communicate panic events to the host.


thanks.
-- 
~Randy