linux-kernel - Re: [PATCH 1/2] misc/pvpanic: split-up generic and platform dependent code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YBrExCSbFu/SCcpW@kroah.com>
Date:   Wed, 3 Feb 2021 16:44:04 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mihai Carabas <mihai.carabas@...cle.com>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        andriy.shevchenko@...ux.intel.com, bobo.shaobowang@...wei.com
Subject: Re: [PATCH 1/2] misc/pvpanic: split-up generic and platform
 dependent code

On Wed, Feb 03, 2021 at 04:43:58PM +0200, Mihai Carabas wrote:
> Split-up generic and platform dependent code in order to introduce pvpanic pci
> device driver later.

What is "later"?

And did you just create a new driver/module in this change?  Why?
And how did you test?  This new module looks to probably taint the
kernel, correct?

How about doing this at the very least, 2 patches, one to move to the
new directory, and the second to split into two modules.  And of course,
please TEST THIS!

thanks,

greg k-h