linux-kernel - Re: [PATCH v7 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp115 ethernet device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPv3WKc0LhtLsBVKBP24pn84cUMj1MCOsCAM18EauxXEPk2zHA@mail.gmail.com>
Date:   Thu, 4 Feb 2021 19:59:52 +0100
From:   Marcin Wojtas <mw@...ihalf.com>
To:     Stefan Chulski <stefanc@...vell.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        "David S. Miller" <davem@...emloft.net>, nadavh@...vell.com,
        Yan Markman <ymarkman@...vell.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Russell King <rmk+kernel@...linux.org.uk>, atenart@...nel.org,
        Konstantin Porotchkin <kostap@...vell.com>
Subject: Re: [PATCH v7 net-next 02/15] dts: marvell: add CM3 SRAM memory to
 cp115 ethernet device tree

Hi,

wt., 2 lut 2021 o 09:17 <stefanc@...vell.com> napisał(a):
>
> From: Konstantin Porotchkin <kostap@...vell.com>
>
> CM3 SRAM address space would be used for Flow Control configuration.
>
> Signed-off-by: Stefan Chulski <stefanc@...vell.com>
> Signed-off-by: Konstantin Porotchkin <kostap@...vell.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> index 9dcf16b..359cf42 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi

The commit message mentions CP115, but the patch updates both CP110
and CP115 - please update one of those (either message or the patch),
so that it is consistent.

Thanks,
Marcin


> @@ -69,6 +69,8 @@
>                         status = "disabled";
>                         dma-coherent;
>
> +                       cm3-mem = <&CP11X_LABEL(cm3_sram)>;
> +
>                         CP11X_LABEL(eth0): eth0 {
>                                 interrupts = <39 IRQ_TYPE_LEVEL_HIGH>,
>                                         <43 IRQ_TYPE_LEVEL_HIGH>,
> @@ -211,6 +213,14 @@
>                         };
>                 };
>
> +               CP11X_LABEL(cm3_sram): cm3@...000 {
> +                       compatible = "mmio-sram";
> +                       reg = <0x220000 0x800>;
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +                       ranges = <0 0x220000 0x800>;
> +               };
> +
>                 CP11X_LABEL(rtc): rtc@...000 {
>                         compatible = "marvell,armada-8k-rtc";
>                         reg = <0x284000 0x20>, <0x284080 0x24>;
> --
> 1.9.1
>