linux-kernel - Re: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210204145201.GB14305@duo.ucw.cz>
Date:   Thu, 4 Feb 2021 15:52:01 +0100
From:   Pavel Machek <pavel@....cz>
To:     Sven Schuchmann <schuchmann@...leissheimer.de>
Cc:     Dan Murphy <dmurphy@...com>, Rob Herring <robh+dt@...nel.org>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity
 from DT

Hi!

> In order to use a multicolor-led together with a trigger
> the led needs to have an intensity set to see something.
> The trigger changes the brightness of the led but if there
> is no intensity we actually see nothing.
> 
> This patch adds the ability to set the default intensity
> of each multi-led node so that it is turned on from DT.
> If no intensity is given the led will be initialized
> with full intensity.
> 
> Part 1 updates the documentation.
> Part 2 removes an unused variable.
> Part 3 sets the initial intensity to full.
> Part 4 reads the default intensity from DT
> 

> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> index c192b5feadc7..2bc25b2fc94d 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> @@ -65,6 +65,11 @@ patternProperties:
>            This property denotes the LED module number(s) that is used on the
>            for the child node.  The LED modules can either be used stand alone
>            or grouped into a module bank.
> +      default-intensity:
> +        minItems: 1
> +        maxItems: 3
> +        description:

Do we need more than three for RGBW and similar?

> +          The default intensity the multi-led gets initialised with.
>  
>      patternProperties:
>        "(^led-[0-9a-f]$|led)":
> @@ -99,6 +104,7 @@ examples:
>                 reg = <0x1>;
>                 color = <LED_COLOR_ID_RGB>;
>                 function = LED_FUNCTION_CHARGING;
> +               default-intensity = <100 0 0>;
>  
>                 led-0 {
>                     color = <LED_COLOR_ID_RED>;

Should this go to leds-class-multicolor.yaml ? Can you make example
<255 120 0> or something like that, so make it clear it is not
percent?

Best regards,
								Pavel

-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)