linux-kernel - AW: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Feb 2021 09:57:44 +0000
From:   Sven Schuchmann <schuchmann@...leissheimer.de>
To:     Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>
CC:     Rob Herring <robh+dt@...nel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: AW: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity
 from DT

Hello Pavel, hello Dan,

> > diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-
> lp50xx.yaml
> > index c192b5feadc7..2bc25b2fc94d 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> > @@ -65,6 +65,11 @@ patternProperties:
> >            This property denotes the LED module number(s) that is used on the
> >            for the child node.  The LED modules can either be used stand alone
> >            or grouped into a module bank.
> > +      default-intensity:
> > +        minItems: 1
> > +        maxItems: 3
> > +        description:
> 
> Do we need more than three for RGBW and similar?

AFAIK the lp50xx supports only RGB. So I would go for that.


> >      patternProperties:
> >        "(^led-[0-9a-f]$|led)":
> > @@ -99,6 +104,7 @@ examples:
> >                 reg = <0x1>;
> >                 color = <LED_COLOR_ID_RGB>;
> >                 function = LED_FUNCTION_CHARGING;
> > +               default-intensity = <100 0 0>;
> >
> >                 led-0 {
> >                     color = <LED_COLOR_ID_RED>;
> 
> Should this go to leds-class-multicolor.yaml ? 

I think then all drivers should support it,  but I cannot change all drivers. 
So I would only leave it in there.


> Can you make example
> <255 120 0> or something like that, so make it clear it is not
> percent?

Sure

Best Regards,

   Sven