linux-kernel - Re: [PATCH] builddeb: Don't look for a missing Module.symvers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <770adfbd-1eaf-3a65-981a-de8e6556e444@seco.com>
Date:   Fri, 5 Feb 2021 10:07:34 -0500
From:   Sean Anderson <sean.anderson@...o.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH] builddeb: Don't look for a missing Module.symvers



On 2/5/21 3:14 AM, Masahiro Yamada wrote:
> On Fri, Feb 5, 2021 at 5:21 AM Sean Anderson <sean.anderson@...o.com> wrote:
>>
>> If deb-pkg is run with CONFIG_MODULES disabled, then make fails with
>>
>> find: ‘Module.symvers’: No such file or directory
>> make[4]: *** [scripts/Makefile.package:87: intdeb-pkg] Error 1
>> make[3]: *** [Makefile:1523: intdeb-pkg] Error 2
>> make[2]: *** [debian/rules:9: binary-arch] Error 2
>>
>> Only add it to headerobjfiles if we actually have modules.
>>
>> Signed-off-by: Sean Anderson <sean.anderson@...o.com>
>> ---
> 
> 
> I do not see this error any more after
> the following commit was merged.

That fixes it on my end as well.

--Sean

> 
> 
> commit bac977cbc0d6731fb8e67c2be0e4acbd959e10b3
> Author: Masahiro Yamada <masahiroy@...nel.org>
> Date:   Wed Oct 14 03:38:19 2020 +0900
> 
>      kbuild: deb-pkg: do not build linux-headers package if CONFIG_MODULES=n
> 
> 
> 
> 
> 
> 
> 
>>   scripts/package/builddeb | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
>> index 91a502bb97e8..19d44704832b 100755
>> --- a/scripts/package/builddeb
>> +++ b/scripts/package/builddeb
>> @@ -71,7 +71,11 @@ deploy_kernel_headers () {
>>                          echo tools/objtool/objtool
>>                  fi
>>
>> -               find arch/$SRCARCH/include Module.symvers include scripts -type f
>> +               if is_enabled CONFIG_MODULES; then
>> +                       echo Module.symvers
>> +               fi
>> +
>> +               find arch/$SRCARCH/include include scripts -type f
>>
>>                  if is_enabled CONFIG_GCC_PLUGINS; then
>>                          find scripts/gcc-plugins -name \*.so
>> --
>> 2.25.1
>>
> 
>