lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 4 Feb 2021 19:50:32 -0500
From:   Peter Xu <>
To:     Jason Gunthorpe <>
        Kirill Shutemov <>,
        Wei Zhang <>,
        Mike Rapoport <>,
        Matthew Wilcox <>,
        Miaohe Lin <>,
        Andrea Arcangeli <>,
        Gal Pressman <>, Jan Kara <>,
        Jann Horn <>,
        Andrew Morton <>,
        Kirill Tkhai <>,
        Linus Torvalds <>,
        Mike Kravetz <>,
        David Gibson <>,
        Christoph Hellwig <>
Subject: Re: [PATCH v2 3/4] mm: Introduce page_needs_cow_for_dma() for
 deciding whether cow

On Thu, Feb 04, 2021 at 07:20:00PM -0400, Jason Gunthorpe wrote:
> > +static inline bool is_cow_mapping(vm_flags_t flags)
> > +{
> It feels a bit more logical to pass in a struct vm_area_struct *' here?

Agree, but only if I'm adding this as a new function.  Though it's a code
movement from internal.h to mm.h, so I avoided touching all the users of this
function that existed.


Peter Xu

Powered by blists - more mailing lists