linux-kernel - Re: [PATCH] soc: ti: k3-ringacc: Use of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7340caba-6975-2bc3-021e-c54a67cbcd18@ti.com>
Date:   Fri, 5 Feb 2021 13:24:01 +0200
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Suman Anna <s-anna@...com>, Santosh Shilimkar <ssantosh@...nel.org>
CC:     Vignesh Raghavendra <vigneshr@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: ti: k3-ringacc: Use of_device_get_match_data()



On 30/01/2021 07:04, Suman Anna wrote:
> Simplify the retrieval of getting the match data in the probe
> function by directly using of_device_get_match_data() instead
> of using of_match_node() and getting data.
> 
> Signed-off-by: Suman Anna <s-anna@...com>
> ---
>   drivers/soc/ti/k3-ringacc.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c
> index b495b0d5d0fa..312ba0f98ad7 100644
> --- a/drivers/soc/ti/k3-ringacc.c
> +++ b/drivers/soc/ti/k3-ringacc.c
> @@ -9,6 +9,7 @@
>   #include <linux/io.h>
>   #include <linux/init.h>
>   #include <linux/of.h>
> +#include <linux/of_device.h>
>   #include <linux/platform_device.h>
>   #include <linux/sys_soc.h>
>   #include <linux/dma/ti-cppi5.h>
> @@ -1517,15 +1518,13 @@ EXPORT_SYMBOL_GPL(k3_ringacc_dmarings_init);
>   static int k3_ringacc_probe(struct platform_device *pdev)
>   {
>   	const struct ringacc_match_data *match_data;
> -	const struct of_device_id *match;
>   	struct device *dev = &pdev->dev;
>   	struct k3_ringacc *ringacc;
>   	int ret;
>   
> -	match = of_match_node(k3_ringacc_of_match, dev->of_node);
> -	if (!match)
> +	match_data = of_device_get_match_data(&pdev->dev);
> +	if (!match_data)
>   		return -ENODEV;
> -	match_data = match->data;
>   
>   	ringacc = devm_kzalloc(dev, sizeof(*ringacc), GFP_KERNEL);
>   	if (!ringacc)
> 

Thank you
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>
-- 
Best regards,
grygorii