linux-kernel - Re: [PATCH net-next 2/7] net: marvell: prestera: disable events interrupt while handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210205112801.GB19627@plvision.eu>
Date:   Fri, 5 Feb 2021 13:28:01 +0200
From:   Vadym Kochan <vadym.kochan@...ision.eu>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        Serhiy Boiko <serhiy.boiko@...ision.eu>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        netdev@...r.kernel.org, Mickey Rachamim <mickeyr@...vell.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/7] net: marvell: prestera: disable events
 interrupt while handling

Hi Jakub,

On Thu, Feb 04, 2021 at 09:10:12PM -0800, Jakub Kicinski wrote:
> On Wed,  3 Feb 2021 18:54:53 +0200 Vadym Kochan wrote:
> > There are change in firmware which requires that receiver will
> > disable event interrupts before handling them and enable them
> > after finish with handling. Events still may come into the queue
> > but without receiver interruption.
> 
> Sounds like you should do a major version bump for this.
> 
> Old driver will not work correctly with new FW.

Right, the old driver version should fail with new fw version.

Thanks, I will re-send new fw version.