linux-kernel - Re: [PATCH 2/2] powercap/intel_rapl: Use topology interface in rapl_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Feb 2021 13:46:26 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Yunfeng Ye <yeyunfeng@...wei.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        "Zhang, Rui" <rui.zhang@...el.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        hushiyuan@...wei.com, hewenliang4@...wei.com, caihongda@...wei.com
Subject: Re: [PATCH 2/2] powercap/intel_rapl: Use topology interface in rapl_init_domains()

On Sat, Jan 23, 2021 at 11:07 AM Yunfeng Ye <yeyunfeng@...wei.com> wrote:
>
> It's not a good way to access the phys_proc_id of cpuinfo directly.
> So using topology_physical_package_id(cpu) instead.
>
> Signed-off-by: Yunfeng Ye <yeyunfeng@...wei.com>

Srinivas, Rui, any concerns?

> ---
>  drivers/powercap/intel_rapl_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index 5f3d39b8212a..8888adcb3927 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -547,7 +547,7 @@ static void rapl_init_domains(struct rapl_package *rp)
>
>                 if (i == RAPL_DOMAIN_PLATFORM && rp->id > 0) {
>                         snprintf(rd->name, RAPL_DOMAIN_NAME_LENGTH, "psys-%d",
> -                               cpu_data(rp->lead_cpu).phys_proc_id);
> +                               topology_physical_package_id(rp->lead_cpu));
>                 } else
>                         snprintf(rd->name, RAPL_DOMAIN_NAME_LENGTH, "%s",
>                                 rapl_domain_names[i]);
> --
> 2.27.0
>