linux-kernel - Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210205112542.335c6bd5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 5 Feb 2021 11:25:42 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Hariprasad Kelam <hkelam@...vell.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        "Geethasowjanya Akula" <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
Subject: Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link
 configuration

On Fri, 5 Feb 2021 14:15:01 +0000 Hariprasad Kelam wrote:
> > > Will add multi advertised mode support in near future.  
> > 
> > Looking at patch 6 it seems like the get side already supports multiple modes,
> > although the example output only lists supported no advertised.
> > 
> > Is the device actually doing IEEE autoneg or just configures the speed, lanes
> > etc. according to the link mode selected?  
> 
> Device supports IEEE autoneg mode. Agreed get_link_ksetting returns multiple modes .  
> But set side  firmware code designed in such way that  it handles  single mode. Upon
> Successful configuration firmware updates advertised modes to shared memory
>  such that kernel will read and updates to ethtool.

It needs to be symmetric, get needs to reflect what set specified.