linux-kernel - Re: [PATCH v2 net-next] net: socket: use BIT() for MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 7 Feb 2021 13:52:33 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     menglong8.dong@...il.com
Cc:     Jens Axboe <axboe@...nel.dk>,
        "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        dong.menglong@....com.cn, Alexander Viro <viro@...iv.linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net-next] net: socket: use BIT() for MSG_*

On Sun, Feb 7, 2021 at 6:32 AM <menglong8.dong@...il.com> wrote:
>
> From: Menglong Dong <dong.menglong@....com.cn>
>
> The bit mask for MSG_* seems a little confused here. Replace it
> with BIT() to make it clear to understand.

Now it's confusing which version maintainer should take (you forgot,
it seems twice, to bump the patch version and mention the changes in
the changelog).

> Changes since v1:
> - use BIT() instead of BIT_MASK()

Moreover, this should go...

>
> Signed-off-by: Menglong Dong <dong.menglong@....com.cn>
> ---

...after this line.

Please, send now a v3 properly.

-- 
With Best Regards,
Andy Shevchenko