linux-kernel - Re: [PATCH iproute2-next V3] devlink: add support for port params get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c22aaccf-59a9-d3bc-8eb3-0496f17c8dc3@gmail.com>
Date:   Mon, 8 Feb 2021 08:41:43 -0700
From:   David Ahern <dsahern@...il.com>
To:     Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        netdev@...r.kernel.org
Cc:     jiri@...dia.com, davem@...emloft.net, linux-kernel@...r.kernel.org,
        kuba@...nel.org
Subject: Re: [PATCH iproute2-next V3] devlink: add support for port params
 get/set

On 2/2/21 6:04 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
> 
> Example:
> $ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value false cmode runtime
> 
> $ devlink port param show netdevsim/netdevsim0/0 name test_port_parameter
> netdevsim/netdevsim0/0:
>   name test_port_parameter type driver-specific
>     values:
>       cmode runtime value false
> 
> $ devlink port  -jp param show netdevsim/netdevsim0/0 name test_port_parameter
> {
>     "param": {
>         "netdevsim/netdevsim0/0": [ {
>                 "name": "test_port_parameter",
>                 "type": "driver-specific",
>                 "values": [ {
>                         "cmode": "runtime",
>                         "value": false
>                     } ]
>             } ]
>     }
> }
> 
> Signed-off-by: Oleksandr Mazur <oleksandr.mazur@...ision.eu>
> ---
> V3:
>     1) Add usage example;
>     2) Remove stray newline in code;
> V2:
>     1) Add bash completion for port param;
>     2) Add man decsription / examples for port param;
> 
>  bash-completion/devlink |  55 ++++++++
>  devlink/devlink.c       | 274 +++++++++++++++++++++++++++++++++++++++-
>  man/man8/devlink-port.8 |  65 ++++++++++
>  3 files changed, 388 insertions(+), 6 deletions(-)
> 

does not apply to iproute2-next. please rebase