linux-kernel - Re: [PATCH iproute2-next V3] devlink: add support for port params get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210205120445.GF4652@nanopsycho.orion>
Date:   Fri, 5 Feb 2021 13:04:45 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Oleksandr Mazur <oleksandr.mazur@...ision.eu>
Cc:     netdev@...r.kernel.org, dsahern@...il.com, jiri@...dia.com,
        davem@...emloft.net, linux-kernel@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH iproute2-next V3] devlink: add support for port params
 get/set

Tue, Feb 02, 2021 at 02:04:45PM CET, oleksandr.mazur@...ision.eu wrote:
>Add implementation for the port parameters
>getting/setting.
>Add bash completion for port param.
>Add man description for port param.
>
>Example:
>$ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value false cmode runtime
>
>$ devlink port param show netdevsim/netdevsim0/0 name test_port_parameter
>netdevsim/netdevsim0/0:
>  name test_port_parameter type driver-specific
>    values:
>      cmode runtime value false
>
>$ devlink port  -jp param show netdevsim/netdevsim0/0 name test_port_parameter
>{
>    "param": {
>        "netdevsim/netdevsim0/0": [ {
>                "name": "test_port_parameter",
>                "type": "driver-specific",
>                "values": [ {
>                        "cmode": "runtime",
>                        "value": false
>                    } ]
>            } ]
>    }
>}
>
>Signed-off-by: Oleksandr Mazur <oleksandr.mazur@...ision.eu>

Looks fine.

Reviewed-by: Jiri Pirko <jiri@...dia.com>