linux-kernel - Re: [patch 01/12] x86/entry: Fix instrumentation annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210205120244.GE17488@zn.tnic>
Date:   Fri, 5 Feb 2021 13:02:44 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [patch 01/12] x86/entry: Fix instrumentation annotation

On Thu, Feb 04, 2021 at 09:49:04PM +0100, Thomas Gleixner wrote:
> Embracing a callout into instrumentation_begin() / instrumentation_begin()
> does not really make sense. Make the latter instrumentation_end().
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  arch/x86/entry/common.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/entry/common.c
> +++ b/arch/x86/entry/common.c
> @@ -270,7 +270,7 @@ static void __xen_pv_evtchn_do_upcall(vo
>  
>  	instrumentation_begin();
>  	run_on_irqstack_cond(__xen_pv_evtchn_do_upcall, regs);
> -	instrumentation_begin();
> +	instrumentation_end();
>  
>  	set_irq_regs(old_regs);

Cc: <stable@...r.kernel.org> ?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette