linux-kernel - Re: [PATCH] kbuild: simplify access to the kernel's version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210208182001.GA4035784@sasha-vm>
Date:   Mon, 8 Feb 2021 13:20:01 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     masahiroy@...nel.org, michal.lkml@...kovi.net,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH] kbuild: simplify access to the kernel's version

On Mon, Feb 08, 2021 at 05:50:07PM +0000, Christoph Hellwig wrote:
>On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote:
>> +		(u8)(LINUX_VERSION_MAJOR), (u8)(LINUX_VERSION_PATCHLEVEL),
>> +		(u16)(LINUX_VERSION_SUBLEVEL));
>
>No need for the casts and braces.
>
>Otherwise this looks good, but please also kill off KERNEL_VERSION
>and LINUX_KERNEL_VERSION entirely while you're at it.

I don't think there are in-tree users left?

We can't remove it completely because userspace is still using it, so if
we drop those userspace will be sad.

-- 
Thanks,
Sasha