linux-kernel - Re: [PATCH] kbuild: simplify access to the kernel's version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQtQTwGt4SCK88a=y4ydASXoR30cCCmcFFdsUk=WY7tfA@mail.gmail.com>
Date:   Fri, 12 Feb 2021 05:18:58 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] kbuild: simplify access to the kernel's version

On Tue, Feb 9, 2021 at 3:20 AM Sasha Levin <sashal@...nel.org> wrote:
>
> On Mon, Feb 08, 2021 at 05:50:07PM +0000, Christoph Hellwig wrote:
> >On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote:
> >> +            (u8)(LINUX_VERSION_MAJOR), (u8)(LINUX_VERSION_PATCHLEVEL),
> >> +            (u16)(LINUX_VERSION_SUBLEVEL));
> >
> >No need for the casts and braces.
> >


I agree.

Shall I remove the casts when I apply this?




> >Otherwise this looks good, but please also kill off KERNEL_VERSION
> >and LINUX_KERNEL_VERSION entirely while you're at it.
>
> I don't think there are in-tree users left?
>
> We can't remove it completely because userspace is still using it, so if
> we drop those userspace will be sad.


Right.
Once we export a macros to userspace, we cannot remove it.





> --
> Thanks,
> Sasha



-- 
Best Regards
Masahiro Yamada