linux-kernel - Re: [PATCH]: checkpatch: Fixed styling issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Feb 2021 20:58:37 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mukul Mehar <mukulmehar02@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: checkpatch: Fixed styling issue

On Tue, Feb 09, 2021 at 01:21:16AM +0530, Mukul Mehar wrote:

> >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001
> From: Mukul Mehar <mukulmehar02@...il.com>
> Date: Mon, 8 Feb 2021 01:03:06 +0530
> Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue.
> 
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
> This is my first patch.
> 
> Signed-off-by: Mukul Mehar <mukulmehar02@...il.com>
> ---
>  drivers/staging/most/sound/sound.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
> index 3a1a59058042..4dd1bf95d1ce 100644
> --- a/drivers/staging/most/sound/sound.c
> +++ b/drivers/staging/most/sound/sound.c
> @@ -228,12 +228,12 @@ static int playback_thread(void *data)
>  		struct mbo *mbo = NULL;
>  		bool period_elapsed = false;
>  
> -		wait_event_interruptible(
> -			channel->playback_waitq,
> -			kthread_should_stop() ||
> -			(channel->is_stream_running &&
> -			 (mbo = most_get_mbo(channel->iface, channel->id,
> -					     &comp))));
> +		wait_event_interruptible(channel->playback_waitq,
> +					 kthread_should_stop() ||
> +					 (channel->is_stream_running &&
> +					 (mbo = most_get_mbo(channel->iface,
> +					 channel->id,
> +					 &comp))));
>  		if (!mbo)
>  			continue;
>  
> -- 
> 2.25.1


Again, all of the things that my bot found last time are still relevant
here.  Please fix them all.

thanks,

greg k-h