linux-kernel - Re: [PATCH]: checkpatch: Fixed styling issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <912a1fcf-4298-5416-805d-3571df66d4d8@infradead.org>
Date:   Mon, 8 Feb 2021 13:21:07 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mukul Mehar <mukulmehar02@...il.com>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: checkpatch: Fixed styling issue

On 2/8/21 11:51 AM, Mukul Mehar wrote:

More comments (probably duplicates):

a. The "checkpatch:" in the subject says that you are making a patch
to the "checkpatch" script. You are not doing that. The subject should
be more like: "staging: most: fix a style issue in sound.c" e.g.

b. This comment:
This is my first patch.

should not be in the comment message. If included at all, it should be
after the "---" line, like so:

---
This is my first patch.

<then the diffstat>.

thanks.
-- 
~Randy