linux-kernel - Re: [PATCH v2] Revert "dmaengine: dw: Enable runtime PM"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210208120609.GC879029@vkoul-mobl.Dlink>
Date:   Mon, 8 Feb 2021 17:36:09 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Cezary Rojewski <cezary.rojewski@...el.com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        dan.j.williams@...el.com, andriy.shevchenko@...ux.intel.com,
        vireshk@...nel.org
Subject: Re: [PATCH v2] Revert "dmaengine: dw: Enable runtime PM"

On 03-02-21, 20:19, Cezary Rojewski wrote:
> This reverts commit 842067940a3e3fc008a60fee388e000219b32632.
> For some solutions e.g. sound/soc/intel/catpt, DW DMA is part of a
> compound device (in that very example, domains: ADSP, SSP0, SSP1, DMA0
> and DMA1 are part of a single entity) rather than being a standalone
> one. Driver for said device may enlist DMA to transfer data during
> suspend or resume sequences.
> 
> Manipulating RPM explicitly in dw's DMA request and release channel
> functions causes suspend() to also invoke resume() for the exact same
> device. Similar situation occurs for resume() sequence. Effectively
> renders device dysfunctional after first suspend() attempt. Revert the
> change to address the problem.

Reverts also need proper tagging, so pls ensure that is done. I have
added the subsystem and driver tags and applied

-- 
~Vinod