linux-kernel - Re: [PATCH v2] openrisc: use device tree to determine present cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXRs_aE7NxC-nUXzskjLQTMG4--mJ23GNFELMY+S9863g@mail.gmail.com>
Date:   Mon, 8 Feb 2021 13:22:46 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Stafford Horne <shorne@...il.com>
Cc:     Jan Henrik Weinstock <jan.weinstock@...h-aachen.de>,
        Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Openrisc <openrisc@...ts.librecores.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] openrisc: use device tree to determine present cpus

Hi Stafford,

On Mon, Feb 8, 2021 at 1:16 PM Stafford Horne <shorne@...il.com> wrote:
> On Sat, Feb 06, 2021 at 10:33:24AM +0100, Geert Uytterhoeven wrote:
> > On Fri, Feb 5, 2021 at 11:36 PM Stafford Horne <shorne@...il.com> wrote:
> > > On Fri, Feb 05, 2021 at 05:07:51PM +0100, Geert Uytterhoeven wrote:
> > > > On Fri, Feb 5, 2021 at 3:43 PM Stafford Horne <shorne@...il.com> wrote:
> > > > > On Mon, Feb 01, 2021 at 12:49:31PM +0100, Jan Henrik Weinstock wrote:
> > > > > > Use the device tree to determine the present cpus instead of assuming all
> > > > > > CONFIG_NRCPUS are actually present in the system.
> > > > > >
> > > > > > Signed-off-by: Jan Henrik Weinstock <jan.weinstock@...h-aachen.de>
> > > > >
> > > > > I cannot apply this patch, it seems you somehow sent it signed as a multipart
> > > > > message via Thunderbird.
> > > > >
> > > > > This causes errors when trying to apply, even after I tried to manually fix the
> > > > > patch mail:
> > > > >
> > > > >     Applying: openrisc: use device tree to determine present cpus
> > > > >     error: sha1 information is lacking or useless (arch/openrisc/kernel/smp.c).
> > > > >     error: could not build fake ancestor
> > > > >     Patch failed at 0001 openrisc: use device tree to determine present cpus
> > > > >
> > > > > Can you send this using 'git send-email?'
> > > > >
> > > > > If not I can get it applied with some work, otherwise you can point me to a git
> > > > > repo which I can pull it from.
> > > >
> > > > "b4 am 6dbc27f8-5261-59c5-acba-70f6c6a74ba1@...h-aachen.de" works
> > > > fine for me.
> > > >
> > > > git://git.kernel.org/pub/scm/utils/b4/b4.git
> > >
> > > Did it work?  For me I got, base not found.
> > >
> > >     Looking up
> > >     https://lore.kernel.org/r/6dbc27f8-5261-59c5-acba-70f6c6a74ba1%40rwth-aachen.de
> > >     Grabbing thread from lore.kernel.org/lkml
> > >     Analyzing 9 messages in the thread
> > >     Will use the latest revision: v2
> > >     You can pick other revisions using the -vN flag
> > >     ---
> > >     Writing
> > >     ./v2_20210201_jan_weinstock_openrisc_use_device_tree_to_determine_present_cpus.mbx
> > >       [PATCH v2] openrisc: use device tree to determine present cpus
> > >     ---
> > >     Total patches: 1
> > >     ---
> > >      Link:
> > >     https://lore.kernel.org/r/6dbc27f8-5261-59c5-acba-70f6c6a74ba1@rwth-aachen.de
> > >      Base: not found
> >
> > That just means the patch contains no information w.r.t. its base, i.e.
> > against which tree/commit it applies to.  To be ignored.
> >
> > >            git am
> > >     ./v2_20210201_jan_weinstock_openrisc_use_device_tree_to_determine_present_cpus.mbx
> >
> > Just run the above command ;-)
> >
> > In addition, you can run "formail -s scripts/checkpatch.pl < *mbx" first, to
> > run the mbox (which could contain multiple patches) through checkpatch.
>
> Thanks for your help, but this is still not working.  See that attached patch.
> If your patch doesn't have this corruption then please forward it.  If Jan could
> point to a git repo or reset with 'git send-email' that would be great too.
>
> It seems that the mailer has corrupted the patch by adding and removing
> whitespace to each line.
>
> I don't have a 'formail' command, but I did try 'git am' and 'checkpatch.pl' and
> it shows:
>
>     < shorne@...nli ~/work/linux > git am v2_20210201_jan_weinstock_openrisc_use_device_tree_to_determine_present_cpus.mbx
>     Applying: openrisc: use device tree to determine present cpus
>     error: corrupt patch at line 62

Indeed, the patch is corrupt.
Sorry for not verifying that before. I just thought you had an issue
saving multipart patches.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds