linux-kernel - Re: [PATCH v5 1/5] Documentation/bindings: phy: update references to cp11x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210210190322.GA2549599@robh.at.kernel.org>
Date:   Wed, 10 Feb 2021 13:03:22 -0600
From:   Rob Herring <robh@...nel.org>
To:     kostap@...vell.com
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, vladimir.vid@...tura.hr,
        tmn505@...il.com, luka.kovacic@...tura.hr,
        sebastian.hesselbarth@...il.com, gregory.clement@...tlin.com,
        andrew@...n.ch, vkoul@...nel.org, kishon@...com,
        miquel.raynal@...tlin.com, mw@...ihalf.com, jaz@...ihalf.com,
        nadavh@...vell.com, stefanc@...vell.com, bpeled@...vell.com
Subject: Re: [PATCH v5 1/5] Documentation/bindings: phy: update references to
 cp11x

On Wed, Feb 10, 2021 at 03:16:00PM +0200, kostap@...vell.com wrote:
> From: Grzegorz Jaszczyk <jaz@...ihalf.com>
> 
> The cp11x references in dts has changed, reflect it in comphy
> documentation.

Who cares. Examples are just examples.

If you really want to improve the binding, convert it to schema.

> Signed-off-by: Grzegorz Jaszczyk <jaz@...ihalf.com>
> Signed-off-by: Konstantin Porotchkin <kostap@...vell.com>
> ---
>  Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> index 8c60e6985950..5ffd0f55d010 100644
> --- a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> @@ -42,22 +42,22 @@ Required properties (child nodes):
>  
>  Examples:
>  
> -	cpm_comphy: phy@...000 {
> +	CP11X_LABEL(comphy): phy@...000 {
>  		compatible = "marvell,comphy-cp110";
>  		reg = <0x120000 0x6000>;
> -		marvell,system-controller = <&cpm_syscon0>;
> -		clocks = <&CP110_LABEL(clk) 1 5>, <&CP110_LABEL(clk) 1 6>,
> -			 <&CP110_LABEL(clk) 1 18>;
> +		marvell,system-controller = <&CP11X_LABEL(syscon0)>;
> +		clocks = <&CP11X_LABEL(clk) 1 5>, <&CP11X_LABEL(clk) 1 6>,
> +			 <&CP11X_LABEL(clk) 1 18>;
>  		clock-names = "mg_clk", "mg_core_clk", "axi_clk";
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		cpm_comphy0: phy@0 {
> +		CP11X_LABEL(comphy0): phy@0 {
>  			reg = <0>;
>  			#phy-cells = <1>;
>  		};
>  
> -		cpm_comphy1: phy@1 {
> +		CP11X_LABEL(comphy1): phy@1 {
>  			reg = <1>;
>  			#phy-cells = <1>;
>  		};
> -- 
> 2.17.1
>