linux-kernel - Re: [PATCH 1/2] Revert "MIPS: kernel: {ftrace,kgdb}: Set correct address limit for cache flushes"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Feb 2021 22:19:08 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Revert "MIPS: kernel: {ftrace,kgdb}: Set correct
 address limit for cache flushes"

On Wed, Feb 10, 2021 at 07:11:00PM +0000, Christoph Hellwig wrote:
> On Wed, Feb 10, 2021 at 05:16:13PM +0100, Thomas Bogendoerfer wrote:
> > This reverts commit 6ebda44f366478d1eea180d93154e7d97b591f50.
> > 
> > All icache flushes in this code paths are done via flush_icache_range(),
> > which only uses normal cache instruction. And this is the correct thing
> > for EVA mode, too. So no need to do set_fs(KERNEL_DS) here.
> > 
> > Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> ... it might be time to kill off the remaining set_fs() users in mips
> code as well ...

I already have patches for that. Still needs some cleaning and testing
before sending/applying it.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]