linux-kernel - Re: [PATCH] sign-file: add openssl engine support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <664916.1612945784@warthog.procyon.org.uk>
Date:   Wed, 10 Feb 2021 08:29:44 +0000
From:   David Howells <dhowells@...hat.com>
To:     Yang Song <songyang@...ux.alibaba.com>
Cc:     dhowells@...hat.com, dwmw2@...radead.org, keyrings@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhang.jia@...ux.alibaba.com,
        tianjia.zhang@...ux.alibaba.com
Subject: Re: [PATCH] sign-file: add openssl engine support

Yang Song <songyang@...ux.alibaba.com> wrote:

> +		"Usage: scripts/sign-file [-edp] [<openssl engine>] <hash algo> <key> <x509> <module> [<dest>]\n");

Do you mean:

		"Usage: scripts/sign-file [-dp] [-e <openssl engine>] <hash algo> <key> <x509> <module> [<dest>]\n");

> +		opt = getopt(argc, argv, "sedpk");

"se:dpk"?

> +		if (use_engine) {
> +			ossl_engine = argv[0];

use_engine ought to be a redundant variable.

David