linux-kernel - Re: [PATCH] enetc: auto select PHYLIB and MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Feb 2021 12:54:35 -0500
From:   Tong Zhang <ztong0001@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Claudiu Manoil <claudiu.manoil@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] enetc: auto select PHYLIB and MDIO_DEVRES

Thanks for the comments!
I have sent a revised patch.
- Tong

On Thu, Feb 11, 2021 at 12:38 PM Florian Fainelli <f.fainelli@...il.com> wrote:
>
> On 2/11/21 8:09 AM, Tong Zhang wrote:
> > FSL_ENETC_MDIO use symbols from PHYLIB and MDIO_DEVRES, however they are
> > not auto selected.
> >
> > ERROR: modpost: "__mdiobus_register" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined!
> > ERROR: modpost: "mdiobus_unregister" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined!
> > ERROR: modpost: "devm_mdiobus_alloc_size" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined!
> >
> > auto select MDIO_DEVRES and PHYLIB when FSL_ENETC_MDIO is selected.
>
> depends on MDIO_DEVRES && MDIO_BUS
>
> would be more appropriate because the symbols you reference are part of
> the MDIO bus layer, which happens to associated with PHYLIB depending on
> the configuration but as far as build goes you can separate the two.
> --
> Florian