linux-kernel - Re: [PATCH] staging: wimax: Fix some coding style problems

Open Source and information security mailing list archives

Message-ID: <YCWT8Gr7huhXTkn4@kroah.com>
Date:   Thu, 11 Feb 2021 21:30:40 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Hemansh Agnihotri <hemanshagnihotri27@...il.com>
Cc:     lee.jones@...aro.org, johannes@...solutions.net, kuba@...nel.org,
        arnd@...db.de, mail@...rudhrb.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wimax: Fix some coding style problems

On Thu, Feb 11, 2021 at 10:43:20PM +0530, Hemansh Agnihotri wrote:
> This fixes checkpatch errors :- "else should follow close brace '}'",
> "space required before the open parenthesis '('" and "spaces required
> around that '?' (ctx:VxW)" in drivers/staging/wimax/i2400m/rx.c file.
> 
> Signed-off-by: Hemansh Agnihotri <hemanshagnihotri27@...il.com>
> ---
>  drivers/staging/wimax/i2400m/rx.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/wimax/i2400m/rx.c b/drivers/staging/wimax/i2400m/rx.c
> index 5b3a85035f6a..8ea0bd039ed7 100644
> --- a/drivers/staging/wimax/i2400m/rx.c
> +++ b/drivers/staging/wimax/i2400m/rx.c
> @@ -485,8 +485,7 @@ struct i2400m_roq_data {
>   * store the sequence number (sn) and the cs (packet type) coming from
>   * the RX payload header from the device.
>   */
> -struct i2400m_roq
> -{
> +struct i2400m_roq {
>  	unsigned ws;
>  	struct sk_buff_head queue;
>  	struct i2400m_roq_log *log;
> @@ -556,7 +555,7 @@ void i2400m_roq_log_entry_print(struct i2400m *i2400m, unsigned index,
>  {
>  	struct device *dev = i2400m_dev(i2400m);
>  
> -	switch(e->type) {
> +	switch (e->type) {
>  	case I2400M_RO_TYPE_RESET:
>  		dev_err(dev, "q#%d reset           ws %u cnt %u sn %u/%u"
>  			" - new nws %u\n",
> @@ -1046,7 +1045,7 @@ void i2400m_rx_edata(struct i2400m *i2400m, struct sk_buff *skb_rx,
>  			 ro_type, ro_cin, roq->ws, ro_sn,
>  			 __i2400m_roq_nsn(roq, ro_sn), size);
>  		d_dump(2, dev, payload, size);
> -		switch(ro_type) {
> +		switch (ro_type) {
>  		case I2400M_RO_TYPE_RESET:
>  			i2400m_roq_reset(i2400m, roq);
>  			kfree_skb(skb);	/* no data here */
> @@ -1346,7 +1345,7 @@ int i2400m_rx_setup(struct i2400m *i2400m)
>  {
>  	int result = 0;
>  
> -	i2400m->rx_reorder = i2400m_rx_reorder_disabled? 0 : 1;
> +	i2400m->rx_reorder = i2400m_rx_reorder_disabled ? 0 : 1;
>  	if (i2400m->rx_reorder) {
>  		unsigned itr;
>  		struct i2400m_roq_log *rd;
> @@ -1365,7 +1364,7 @@ int i2400m_rx_setup(struct i2400m *i2400m)
>  			goto error_roq_log_alloc;
>  		}
>  
> -		for(itr = 0; itr < I2400M_RO_CIN + 1; itr++) {
> +		for (itr = 0; itr < I2400M_RO_CIN + 1; itr++) {
>  			__i2400m_roq_init(&i2400m->rx_roq[itr]);
>  			i2400m->rx_roq[itr].log = &rd[itr];
>  		}
> -- 
> 2.30.0
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives